lkml.org 
[lkml]   [2018]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 164/173] ASoC: samsung: Fix invalid argument when devm_gpiod_get is called
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jaechul Lee <jcsing.lee@samsung.com>

    commit 975b6a93088e83a41ba2f0dec2f086678fdb2a7a upstream.

    devm_gpiod_get is called with GPIOF_OUT_INIT_LOW but the function doesn't
    allow the parameters. Unluckily, GPIOF_OUT_INIT_LOW is same value as
    GPIOD_ASIS and gpio direction isn't set properly.

    Muted stream comes up when I try recording some sounds on TM2. mic-bias
    gpiod state can't be changed because the gpiod is created with the invalid
    parameter. The gpio should be set GPIOD_OUT_HIGH.

    Fixes: 1bfbc260a5b4 ("ASoC: samsung: Add machine driver for Exynos5433 based TM2 board")
    Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
    Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/soc/samsung/tm2_wm5110.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/sound/soc/samsung/tm2_wm5110.c
    +++ b/sound/soc/samsung/tm2_wm5110.c
    @@ -436,8 +436,7 @@ static int tm2_probe(struct platform_dev
    snd_soc_card_set_drvdata(card, priv);
    card->dev = dev;

    - priv->gpio_mic_bias = devm_gpiod_get(dev, "mic-bias",
    - GPIOF_OUT_INIT_LOW);
    + priv->gpio_mic_bias = devm_gpiod_get(dev, "mic-bias", GPIOD_OUT_HIGH);
    if (IS_ERR(priv->gpio_mic_bias)) {
    dev_err(dev, "Failed to get mic bias gpio\n");
    return PTR_ERR(priv->gpio_mic_bias);

    \
     
     \ /
      Last update: 2018-09-24 14:54    [W:2.027 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site