lkml.org 
[lkml]   [2018]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.18 029/235] clk: imx6sll: fix missing of_node_put()
    Date
    4.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Nicholas Mc Guire <hofrat@osadl.org>

    [ Upstream commit 7f5eac5934d747535f9ffc997792a0a6eb289374 ]

    of_find_compatible_node() is returning a device node with refcount
    incremented and must be explicitly decremented after the last use
    which is right after the us in of_iomap() here.

    Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
    Fixes: 4a5f720b6542 ("clk: imx: add clock driver for imx6sll")
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/clk/imx/clk-imx6sll.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/clk/imx/clk-imx6sll.c
    +++ b/drivers/clk/imx/clk-imx6sll.c
    @@ -92,6 +92,7 @@ static void __init imx6sll_clocks_init(s

    np = of_find_compatible_node(NULL, NULL, "fsl,imx6sll-anatop");
    base = of_iomap(np, 0);
    + of_node_put(np);
    WARN_ON(!base);

    /* Do not bypass PLLs initially */

    \
     
     \ /
      Last update: 2018-09-24 14:52    [W:2.214 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site