lkml.org 
[lkml]   [2018]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.18 158/235] PM / devfreq: use put_device() instead of kfree()
    Date
    4.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Arvind Yadav <arvind.yadav.cs@gmail.com>

    [ Upstream commit 2d803dc8f7a5f622ac47c3b650834ada3a2659b9 ]

    Never directly free @dev after calling device_register() or
    device_unregister(), even if device_register() returned an error.
    Always use put_device() to give up the reference initialized.

    Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
    Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
    Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/devfreq/devfreq.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/devfreq/devfreq.c
    +++ b/drivers/devfreq/devfreq.c
    @@ -625,7 +625,8 @@ struct devfreq *devfreq_add_device(struc
    err = device_register(&devfreq->dev);
    if (err) {
    mutex_unlock(&devfreq->lock);
    - goto err_dev;
    + put_device(&devfreq->dev);
    + goto err_out;
    }

    devfreq->trans_table =
    @@ -672,6 +673,7 @@ err_init:
    mutex_unlock(&devfreq_list_lock);

    device_unregister(&devfreq->dev);
    + devfreq = NULL;
    err_dev:
    if (devfreq)
    kfree(devfreq);

    \
     
     \ /
      Last update: 2018-09-24 14:50    [W:5.032 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site