lkml.org 
[lkml]   [2018]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.18 198/235] lightnvm: pblk: enable line minor version detection
    Date
    4.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Matias Bjørling <mb@lightnvm.io>

    [ Upstream commit 99b8dad1b6e52721904220322a947f7b75056303 ]

    When recovering a line, an extra check was added when debugging was
    active, such that minor version where also checked. Unfortunately,
    this used the ifdef NVM_DEBUG, which is not correct.

    Instead use the proper DEBUG def, and now that it compiles, also fix
    the variable.

    Signed-off-by: Matias Bjørling <mb@lightnvm.io>
    Fixes: d0ab0b1ab991f ("lightnvm: pblk: check data lines version on recovery")
    Reviewed-by: Javier González <javier@cnexlabs.com>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/lightnvm/pblk-recovery.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    --- a/drivers/lightnvm/pblk-recovery.c
    +++ b/drivers/lightnvm/pblk-recovery.c
    @@ -742,9 +742,10 @@ static int pblk_recov_check_line_version
    return 1;
    }

    -#ifdef NVM_DEBUG
    +#ifdef CONFIG_NVM_PBLK_DEBUG
    if (header->version_minor > EMETA_VERSION_MINOR)
    - pr_info("pblk: newer line minor version found: %d\n", line_v);
    + pr_info("pblk: newer line minor version found: %d\n",
    + header->version_minor);
    #endif

    return 0;

    \
     
     \ /
      Last update: 2018-09-24 14:49    [W:4.022 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site