lkml.org 
[lkml]   [2018]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.18 188/235] parport: sunbpp: fix error return code
    Date
    4.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Julia Lawall <Julia.Lawall@lip6.fr>

    [ Upstream commit faa1a47388b33623e4d504c23569188907b039a0 ]

    Return an error code on failure. Change leading spaces to tab on the
    first if.

    Problem found using Coccinelle.

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
    Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/parport/parport_sunbpp.c | 8 ++++++--
    1 file changed, 6 insertions(+), 2 deletions(-)

    --- a/drivers/parport/parport_sunbpp.c
    +++ b/drivers/parport/parport_sunbpp.c
    @@ -286,12 +286,16 @@ static int bpp_probe(struct platform_dev

    ops = kmemdup(&parport_sunbpp_ops, sizeof(struct parport_operations),
    GFP_KERNEL);
    - if (!ops)
    + if (!ops) {
    + err = -ENOMEM;
    goto out_unmap;
    + }

    dprintk(("register_port\n"));
    - if (!(p = parport_register_port((unsigned long)base, irq, dma, ops)))
    + if (!(p = parport_register_port((unsigned long)base, irq, dma, ops))) {
    + err = -ENOMEM;
    goto out_free_ops;
    + }

    p->size = size;
    p->dev = &op->dev;

    \
     
     \ /
      Last update: 2018-09-24 14:42    [W:2.703 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site