lkml.org 
[lkml]   [2018]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.18 097/235] PCI/AER: Honor "pcie_ports=native" even if HEST sets FIRMWARE_FIRST
    Date
    4.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Alexandru Gagniuc <mr.nuke.me@gmail.com>

    [ Upstream commit 7af02fcd84c16801958936f88b848944c726ca07 ]

    According to the documentation, "pcie_ports=native", linux should use
    native AER and DPC services. While that is true for the _OSC method
    parsing, this is not the only place that is checked. Should the HEST
    list PCIe ports as firmware-first, linux will not use native services.

    This happens because aer_acpi_firmware_first() doesn't take 'pcie_ports'
    into account. This is wrong. DPC uses the same logic when it decides
    whether to load or not, so fixing this also fixes DPC not loading.

    Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
    [bhelgaas: return "false" from bool function (from kbuild robot)]
    Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/pci/pcie/aer.c | 6 ++++++
    1 file changed, 6 insertions(+)

    --- a/drivers/pci/pcie/aer.c
    +++ b/drivers/pci/pcie/aer.c
    @@ -303,6 +303,9 @@ int pcie_aer_get_firmware_first(struct p
    if (!pci_is_pcie(dev))
    return 0;

    + if (pcie_ports_native)
    + return 0;
    +
    if (!dev->__aer_firmware_first_valid)
    aer_set_firmware_first(dev);
    return dev->__aer_firmware_first;
    @@ -323,6 +326,9 @@ bool aer_acpi_firmware_first(void)
    .firmware_first = 0,
    };

    + if (pcie_ports_native)
    + return false;
    +
    if (!parsed) {
    apei_hest_parse(aer_hest_parse, &info);
    aer_firmware_first = info.firmware_first;

    \
     
     \ /
      Last update: 2018-09-24 14:35    [W:4.190 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site