lkml.org 
[lkml]   [2018]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 080/173] mmc: omap_hsmmc: fix wakeirq handling on removal
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Andreas Kemnade <andreas@kemnade.info>

    commit 3c398f3c3bef21961eaaeb93227fa66d440dc83d upstream.

    after unbinding mmc I get things like this:
    [ 185.294067] mmc1: card 0001 removed
    [ 185.305206] omap_hsmmc 480b4000.mmc: wake IRQ with no resume: -13

    The wakeirq stays in /proc-interrupts

    rebinding shows this:
    [ 289.795959] genirq: Flags mismatch irq 112. 0000200a (480b4000.mmc:wakeup) vs. 0000200a (480b4000.mmc:wakeup)
    [ 289.808959] omap_hsmmc 480b4000.mmc: Unable to request wake IRQ
    [ 289.815338] omap_hsmmc 480b4000.mmc: no SDIO IRQ support, falling back to polling

    That bug seems to be introduced by switching from devm_request_irq()
    to generic wakeirq handling.

    So let us cleanup at removal.

    Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
    Fixes: 5b83b2234be6 ("mmc: omap_hsmmc: Change wake-up interrupt to use generic wakeirq")
    Cc: stable@vger.kernel.org # v4.2+
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/mmc/host/omap_hsmmc.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/mmc/host/omap_hsmmc.c
    +++ b/drivers/mmc/host/omap_hsmmc.c
    @@ -2194,6 +2194,7 @@ static int omap_hsmmc_remove(struct plat
    dma_release_channel(host->tx_chan);
    dma_release_channel(host->rx_chan);

    + dev_pm_clear_wake_irq(host->dev);
    pm_runtime_dont_use_autosuspend(host->dev);
    pm_runtime_put_sync(host->dev);
    pm_runtime_disable(host->dev);

    \
     
     \ /
      Last update: 2018-09-24 14:21    [W:5.952 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site