lkml.org 
[lkml]   [2018]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 096/111] rtc: bq4802: add error handling for devm_ioremap
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Zhouyang Jia <jiazhouyang09@gmail.com>

    [ Upstream commit 7874b919866ba91bac253fa219d3d4c82bb944df ]

    When devm_ioremap fails, the lack of error-handling code may
    cause unexpected results.

    This patch adds error-handling code after calling devm_ioremap.

    Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com>
    Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/rtc/rtc-bq4802.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/drivers/rtc/rtc-bq4802.c
    +++ b/drivers/rtc/rtc-bq4802.c
    @@ -164,6 +164,10 @@ static int bq4802_probe(struct platform_
    } else if (p->r->flags & IORESOURCE_MEM) {
    p->regs = devm_ioremap(&pdev->dev, p->r->start,
    resource_size(p->r));
    + if (!p->regs){
    + err = -ENOMEM;
    + goto out;
    + }
    p->read = bq4802_read_mem;
    p->write = bq4802_write_mem;
    } else {

    \
     
     \ /
      Last update: 2018-09-24 14:08    [W:4.389 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site