lkml.org 
[lkml]   [2018]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 025/111] video: fbdev: pxafb: clear allocated memory for video modes
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Daniel Mack <daniel@zonque.org>

    [ Upstream commit b951d80aaf224b1f774e10def672f5e37488e4ee ]

    When parsing the video modes from DT properties, make sure to zero out
    memory before using it. This is important because not all fields in the mode
    struct are explicitly initialized, even though they are used later on.

    Fixes: 420a488278e86 ("video: fbdev: pxafb: initial devicetree conversion")
    Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr>
    Signed-off-by: Daniel Mack <daniel@zonque.org>
    Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/video/fbdev/pxafb.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/video/fbdev/pxafb.c
    +++ b/drivers/video/fbdev/pxafb.c
    @@ -2128,8 +2128,8 @@ static int of_get_pxafb_display(struct d
    return -EINVAL;

    ret = -ENOMEM;
    - info->modes = kmalloc_array(timings->num_timings,
    - sizeof(info->modes[0]), GFP_KERNEL);
    + info->modes = kcalloc(timings->num_timings, sizeof(info->modes[0]),
    + GFP_KERNEL);
    if (!info->modes)
    goto out;
    info->num_modes = timings->num_timings;

    \
     
     \ /
      Last update: 2018-09-24 14:00    [W:2.924 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site