lkml.org 
[lkml]   [2018]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 019/111] perf test: Fix subtest number when showing results
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Thomas Richter <tmricht@linux.ibm.com>

    [ Upstream commit 9ef0112442bdddef5fb55adf20b3a5464b33de75 ]

    Perf test 40 for example has several subtests numbered 1-4 when
    displaying the start of the subtest. When the subtest results
    are displayed the subtests are numbered 0-3.

    Use this command to generate trace output:

    [root@s35lp76 perf]# ./perf test -Fv 40 2>/tmp/bpf1

    Fix this by adjusting the subtest number when show the
    subtest result.

    Output before:

    [root@s35lp76 perf]# egrep '(^40\.[0-4]| subtest [0-4]:)' /tmp/bpf1
    40.1: Basic BPF filtering :
    BPF filter subtest 0: Ok
    40.2: BPF pinning :
    BPF filter subtest 1: Ok
    40.3: BPF prologue generation :
    BPF filter subtest 2: Ok
    40.4: BPF relocation checker :
    BPF filter subtest 3: Ok
    [root@s35lp76 perf]#

    Output after:

    root@s35lp76 ~]# egrep '(^40\.[0-4]| subtest [0-4]:)' /tmp/bpf1
    40.1: Basic BPF filtering :
    BPF filter subtest 1: Ok
    40.2: BPF pinning :
    BPF filter subtest 2: Ok
    40.3: BPF prologue generation :
    BPF filter subtest 3: Ok
    40.4: BPF relocation checker :
    BPF filter subtest 4: Ok
    [root@s35lp76 ~]#

    Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
    Reviewed-by: Hendrik Brueckner <brueckner@linux.ibm.com>
    Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
    Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
    Link: http://lkml.kernel.org/r/20180724134858.100644-1-tmricht@linux.ibm.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    tools/perf/tests/builtin-test.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/tools/perf/tests/builtin-test.c
    +++ b/tools/perf/tests/builtin-test.c
    @@ -413,7 +413,7 @@ static int __cmd_test(int argc, const ch
    for (subi = 0; subi < subn; subi++) {
    pr_info("%2d.%1d: %-*s:", i, subi + 1, subw,
    t->subtest.get_desc(subi));
    - err = test_and_print(t, skip, subi);
    + err = test_and_print(t, skip, subi + 1);
    if (err != TEST_OK && t->subtest.skip_if_fail)
    skip = true;
    }

    \
     
     \ /
      Last update: 2018-09-24 14:00    [W:4.184 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site