lkml.org 
[lkml]   [2018]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 022/111] video: goldfishfb: fix memory leak on driver remove
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Anton Vasilyev <vasilyev@ispras.ru>

    [ Upstream commit 5958fde72d04e7b8c6de3669d1f794a90997e3eb ]

    goldfish_fb_probe() allocates memory for fb, but goldfish_fb_remove() does
    not have deallocation of fb, which leads to memory leak on probe/remove.

    The patch adds deallocation into goldfish_fb_remove().

    Found by Linux Driver Verification project (linuxtesting.org).

    Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
    Cc: Aleksandar Markovic <aleksandar.markovic@mips.com>
    Cc: Miodrag Dinic <miodrag.dinic@mips.com>
    Cc: Goran Ferenc <goran.ferenc@mips.com>
    Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/video/fbdev/goldfishfb.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/video/fbdev/goldfishfb.c
    +++ b/drivers/video/fbdev/goldfishfb.c
    @@ -301,6 +301,7 @@ static int goldfish_fb_remove(struct pla
    dma_free_coherent(&pdev->dev, framesize, (void *)fb->fb.screen_base,
    fb->fb.fix.smem_start);
    iounmap(fb->reg_base);
    + kfree(fb);
    return 0;
    }


    \
     
     \ /
      Last update: 2018-09-24 14:00    [W:4.074 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site