lkml.org 
[lkml]   [2018]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 015/105] scsi: aic94xx: fix an error code in aic94xx_init()
    Date
    3.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 0756c57bce3d26da2592d834d8910b6887021701 ]

    We accidentally return success instead of -ENOMEM on this error path.

    Fixes: 2908d778ab3e ("[SCSI] aic94xx: new driver")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
    Reviewed-by: John Garry <john.garry@huawei.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/scsi/aic94xx/aic94xx_init.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/scsi/aic94xx/aic94xx_init.c
    +++ b/drivers/scsi/aic94xx/aic94xx_init.c
    @@ -1047,8 +1047,10 @@ static int __init aic94xx_init(void)

    aic94xx_transport_template =
    sas_domain_attach_transport(&aic94xx_transport_functions);
    - if (!aic94xx_transport_template)
    + if (!aic94xx_transport_template) {
    + err = -ENOMEM;
    goto out_destroy_caches;
    + }

    err = pci_register_driver(&aic94xx_pci_driver);
    if (err)

    \
     
     \ /
      Last update: 2018-09-24 13:49    [W:4.038 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site