Messages in this thread | | | Subject | Re: [PATCH] usb: cdc_acm: Do not leak URB buffers | From | Oliver Neukum <> | Date | Mon, 24 Sep 2018 13:28:38 +0200 |
| |
On Do, 2018-09-20 at 16:49 +0200, Romain Izard wrote: > When the ACM TTY port is disconnected, the URBs it uses must be killed, and > then the buffers must be freed. Unfortunately a previous refactor removed > the code freeing the buffers because it looked extremely similar to the > code killing the URBs. > > As a result, there were many new leaks for each plug/unplug cycle of a > CDC-ACM device, that were detected by kmemleak. > > Restore the missing code, and the memory leak is removed. > > Fixes: ba8c931ded8d ("cdc-acm: refactor killing urbs") > Signed-off-by: Romain Izard <romain.izard.pro@gmail.com> Acked-by: Oliver Neukum <oneukum@suse.com>
| |