lkml.org 
[lkml]   [2018]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH net 4/7] sr9800: Check for supported Wake-on-LAN modes
    Date
    The driver currently silently accepts unsupported Wake-on-LAN modes
    (other than WAKE_PHY or WAKE_MAGIC) without reporting that to the user,
    which is confusing.

    Fixes: 19a38d8e0aa3 ("USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 Device Driver Support")
    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    ---
    drivers/net/usb/sr9800.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/net/usb/sr9800.c b/drivers/net/usb/sr9800.c
    index 9277a0f228df..35f39f23d881 100644
    --- a/drivers/net/usb/sr9800.c
    +++ b/drivers/net/usb/sr9800.c
    @@ -421,6 +421,9 @@ sr_set_wol(struct net_device *net, struct ethtool_wolinfo *wolinfo)
    struct usbnet *dev = netdev_priv(net);
    u8 opt = 0;

    + if (wolinfo->wolopts & ~(WAKE_PHY | WAKE_MAGIC))
    + return -EINVAL;
    +
    if (wolinfo->wolopts & WAKE_PHY)
    opt |= SR_MONITOR_LINK;
    if (wolinfo->wolopts & WAKE_MAGIC)
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-09-24 22:56    [W:4.353 / U:0.480 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site