Messages in this thread | | | Subject | Re: [PATCH] iw_cxgb4: Use proper enumerated type in c4iw_bar2_addrs | From | Steve Wise <> | Date | Mon, 24 Sep 2018 14:41:26 -0500 |
| |
On 9/24/2018 2:29 PM, Nathan Chancellor wrote: > Clang warns when one enumerated type is implicitly converted to another. > > drivers/infiniband/hw/cxgb4/qp.c:287:8: warning: implicit conversion > from enumeration type 'enum t4_bar2_qtype' to different enumeration type > 'enum cxgb4_bar2_qtype' [-Wenum-conversion] > T4_BAR2_QTYPE_EGRESS, > ^~~~~~~~~~~~~~~~~~~~ > > c4iw_bar2_addrs expects a value from enum cxgb4_bar2_qtype so use the > corresponding values from that type so Clang is satisfied without > changing the meaning of the code. > > T4_BAR2_QTYPE_EGRESS = CXGB4_BAR2_QTYPE_EGRESS = 0 > T4_BAR2_QTYPE_INGRESS = CXGB4_BAR2_QTYPE_INGRESS = 1 > > Reported-by: Nick Desaulniers <ndesaulniers@google.com> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Looks correct, Thanks.
Acked-by: Steve Wise <swise@opengridcomputing.com>
| |