lkml.org 
[lkml]   [2018]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3.18 104/105] IB/nes: Fix a compiler warning
From
Date
On Mon, 2018-09-24 at 19:59 +0200, Greg Kroah-Hartman wrote:
> On Mon, Sep 24, 2018 at 09:38:26AM -0700, Joe Perches wrote:
> > On Mon, 2018-09-24 at 13:34 +0200, Greg Kroah-Hartman wrote:
> > > 3.18-stable review patch. If anyone has any objections, please let me know.
> >
> > Why should this sort of change be applied to a stable release?
>
> Originally I was just going to drop this as it's not fixing something.
>
> But it might be, if that macro is used in a if() statement, or something
> like that, it could be doing something unintended.

No it couldn't.
An empty macro is equivalent to a single statement.

> So I don't feel like auditing all 500+ instances where this is used,
> it's easier to just accept the patch.

It's not a bug fix.

\
 
 \ /
  Last update: 2018-09-24 20:05    [W:0.101 / U:0.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site