Messages in this thread | | | Date | Mon, 24 Sep 2018 09:46:53 -0700 | From | Eduardo Valentin <> | Subject | Re: [PATCH 01/17] thermal: add thermal_zone_device_toggle() helper |
| |
On Mon, Sep 17, 2018 at 11:33:59AM +0200, Bartlomiej Zolnierkiewicz wrote: > > On 09/14/2018 01:40 PM, Bartlomiej Zolnierkiewicz wrote: > > [...] > > >>> --- a/include/linux/thermal.h > >>> +++ b/include/linux/thermal.h > >>> @@ -467,6 +467,7 @@ struct thermal_cooling_device * > >>> int thermal_zone_get_temp(struct thermal_zone_device *tz, int *temp); > >>> int thermal_zone_get_slope(struct thermal_zone_device *tz); > >>> int thermal_zone_get_offset(struct thermal_zone_device *tz); > >>> +int thermal_zone_device_toggle(struct thermal_zone_device *tz, bool on); > >>> > >> > >> You missed the #else section of the #if IS_ENABLED(CONFIG_THERMAL), > >> didn't you? > > > > No, this function shouldn't be used outside of CONFIG_THERMAL. > > Please disregard my previous comment. I see now that the CONFIG_THERMAL=n > stub is needed and I will add it in the next patch revision.
Thanks Bartolomiej for keeping this up.
> > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics
| |