Messages in this thread | | | Date | Mon, 24 Sep 2018 09:45:32 -0700 | From | Eduardo Valentin <> | Subject | Re: [PATCH] thermal: power_allocator: remove early break |
| |
Hey,
On Fri, Sep 21, 2018 at 02:06:09PM +0100, Willy Wolff wrote: > If a trip of type critical is defined before any trip of passive > or active type, power_allocator governor will not switch on.
But, if a critical trip is reached, the expectation is to perform a thermal shutdown. Why would you expect to have power allocator to be activated during the process of a shutdown?
> > Signed-off-by: Willy Wolff <willy.mh.wolff.ml@gmail.com> > --- > drivers/thermal/power_allocator.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/thermal/power_allocator.c b/drivers/thermal/power_allocator.c > index 3055f9a12a17..6544b68e3ebf 100644 > --- a/drivers/thermal/power_allocator.c > +++ b/drivers/thermal/power_allocator.c > @@ -496,8 +496,6 @@ static void get_governor_trips(struct thermal_zone_device *tz, > } > } else if (type == THERMAL_TRIP_ACTIVE) { > last_active = i; > - } else { > - break; > } > } > > -- > 2.11.0 >
| |