Messages in this thread | | | Subject | Re: [PATCH v10 10/26] KVM: s390: interfaces to clear CRYCB masks | From | Tony Krowiak <> | Date | Mon, 24 Sep 2018 11:33:43 -0400 |
| |
On 09/24/2018 08:01 AM, Cornelia Huck wrote: > On Mon, 24 Sep 2018 13:50:36 +0200 > Halil Pasic <pasic@linux.ibm.com> wrote: > >> On 09/24/2018 01:01 PM, Cornelia Huck wrote: >>> On Wed, 12 Sep 2018 15:43:00 -0400 >>> Tony Krowiak <akrowiak@linux.vnet.ibm.com> wrote: >>> >>>> From: Tony Krowiak <akrowiak@linux.ibm.com> >>>> >>>> Introduces two new KVM interface to clear the APM, AQM and ADM masks in >>>> the guest's CRYCB. The VCPUs are taken out of SIE to ensure the VCPUs do >>>> not get out of sync. >>> >>> Hm, that patch description does not quite match what the patch actually >>> does... >>> >> >> You mean it is not obvious where the masks get cleared? Well the APCB is >> defined to contain exactly the three masks. As far as I can tell the patch >> description is correct. > > No, I was referring to "two new KVM interface[s]". The patch just > introduces a new function that clears the masks (well, maybe you can > call this an "interface"). So > > s/two new KVM interface/a function in KVM/ > > and I'd be happy :) (sorry for being too vague)
I'm not quite sure why this is not an interface, but this is not a hill I'm willing to die on. And, I agree, there are not two of them. I'll make the change.
>
| |