lkml.org 
[lkml]   [2018]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 28/36] fs/cifs: don't translate SFM_SLASH (U+F026) to backslash
    Date
    From: Jon Kuhn <jkuhn@barracuda.com>

    [ Upstream commit c15e3f19a6d5c89b1209dc94b40e568177cb0921 ]

    When a Mac client saves an item containing a backslash to a file server
    the backslash is represented in the CIFS/SMB protocol as as U+F026.
    Before this change, listing a directory containing an item with a
    backslash in its name will return that item with the backslash
    represented with a true backslash character (U+005C) because
    convert_sfm_character mapped U+F026 to U+005C when interpretting the
    CIFS/SMB protocol response. However, attempting to open or stat the
    path using a true backslash will result in an error because
    convert_to_sfm_char does not map U+005C back to U+F026 causing the
    CIFS/SMB request to be made with the backslash represented as U+005C.

    This change simply prevents the U+F026 to U+005C conversion from
    happenning. This is analogous to how the code does not do any
    translation of UNI_SLASH (U+F000).

    Signed-off-by: Jon Kuhn <jkuhn@barracuda.com>
    Signed-off-by: Steve French <stfrench@microsoft.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    fs/cifs/cifs_unicode.c | 3 ---
    1 file changed, 3 deletions(-)

    diff --git a/fs/cifs/cifs_unicode.c b/fs/cifs/cifs_unicode.c
    index b380e0871372..a2b2355e7f01 100644
    --- a/fs/cifs/cifs_unicode.c
    +++ b/fs/cifs/cifs_unicode.c
    @@ -105,9 +105,6 @@ convert_sfm_char(const __u16 src_char, char *target)
    case SFM_LESSTHAN:
    *target = '<';
    break;
    - case SFM_SLASH:
    - *target = '\\';
    - break;
    case SFM_SPACE:
    *target = ' ';
    break;
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-09-24 16:57    [W:3.652 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site