lkml.org 
[lkml]   [2018]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] clk: qcom: Add Global Clock controller (GCC) driver for SDM660
    From


    On 24 September 2018 13:44:33 BST, Heiko Stuebner <heiko@sntech.de> wrote:
    >Hi Craig,
    >
    >Am Montag, 13. August 2018, 09:45:09 CEST schrieb Craig Tatlor:
    >> On 13 August 2018 07:55:34 BST, Taniya Das <tdas@codeaurora.org>
    >wrote:
    >> >Hello Craig,
    >> >
    >> >Could you please correct the authorship and also provide the
    >reference
    >> >to code where this is picked from?
    >> Okay,
    >> Got code from here
    >https://github.com/sonyxperiadev/kernel/blob/aosp/LA.UM.6.4.r1/drivers/clk/qcom/gcc-sdm660.c
    >> but changed it quite a bit for upstream,
    >> Should I change the commit author and add your signed off by and say
    >I did cleanups on my signed off by.
    >
    >yep, for something this huge it is really the correct way to keep the
    >original authorship intact as Taniya did the initial big work, and just
    >add you change-description, so something like
    >
    >---- 8< ------
    >Add support for the global clock controller found on SDM660
    >based devices. This should allow most non-multimedia device
    >drivers to probe and control their clocks.
    >Based on CAF implementation.
    >
    >Signed-off-by: Taniya Das <tdas@codeaurora.org>
    >[ description of changes ... often seen in these brackets ]
    >Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
    >---- 8< ------
    >
    Sure, will do, though I'm sure qcom have a program to generate the drivers :)

    >Also, do you plan to continue working on this, as I would be
    >interessted
    >in the clock driver for a sdm660-based phone as well
    Yup, was really just waiting for reply to this question,
    >
    >
    >Thanks
    >Heiko

    --

    \
     
     \ /
      Last update: 2018-09-24 16:34    [W:2.870 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site