Messages in this thread | | | From | Heiko Stuebner <> | Subject | Re: [PATCH] arm64: dts: rockchip: update pinmux setting in rk3399.dtsi | Date | Mon, 24 Sep 2018 14:58:15 +0200 |
| |
Hi Akash,
Am Mittwoch, 19. September 2018, 16:45:15 CEST schrieb Akash Gajjar: > replace pin numbers with equivalent pin macro in rk3399.dtsi > > Signed-off-by: Akash Gajjar <Akash_Gajjar@mentor.com>
so far my "policy" has been to have new stuff use the constants but not mass-converting the old entries, due to me being anxious about accidentially breaking some seldom used settings.
With the newly added linebreaks your change looks pretty much hand- generated, so I guess there is a bit of probability for typos creeping in and it of course also only adapts one of the Rockchip socs.
So while I _may_ be persuaded of a scripted conversion [including seeing the script] doing all Rockchip socs (per architecture) at once, I currently somehow prefer keeping the status quo ;-)
Heiko
| |