Messages in this thread | | | From | Vabhav Sharma <> | Subject | RE: [PATCH v2 3/5] drivers: clk-qoriq: Add clockgen support for lx2160a | Date | Mon, 24 Sep 2018 11:56:08 +0000 |
| |
> -----Original Message----- > From: Scott Wood <oss@buserror.net> > Sent: Sunday, September 16, 2018 12:54 AM > To: Vabhav Sharma <vabhav.sharma@nxp.com>; sudeep.holla@arm.com; linux- > kernel@vger.kernel.org; devicetree@vger.kernel.org; robh+dt@kernel.org; > mark.rutland@arm.com; linuxppc-dev@lists.ozlabs.org; linux-arm- > kernel@lists.infradead.org; mturquette@baylibre.com; sboyd@kernel.org; > rjw@rjwysocki.net; viresh.kumar@linaro.org; linux-clk@vger.kernel.org; linux- > pm@vger.kernel.org; linux-kernel-owner@vger.kernel.org; > catalin.marinas@arm.com; will.deacon@arm.com; > gregkh@linuxfoundation.org; arnd@arndb.de; kstewart@linuxfoundation.org; > yamada.masahiro@socionext.com > Cc: linux@armlinux.org.uk; Varun Sethi <V.Sethi@nxp.com>; Udit Kumar > <udit.kumar@nxp.com>; Yogesh Narayan Gaur > <yogeshnarayan.gaur@nxp.com>; Andy Tang <andy.tang@nxp.com> > Subject: Re: [PATCH v2 3/5] drivers: clk-qoriq: Add clockgen support for lx2160a > > On Fri, 2018-09-14 at 02:07 +0530, Vabhav Sharma wrote: > > From: Yogesh Gaur <yogeshnarayan.gaur@nxp.com> > > > > Add clockgen support for lx2160a. > > Added entry for compat 'fsl,lx2160a-clockgen'. > > > > Signed-off-by: Tang Yuantian <andy.tang@nxp.com> > > Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com> > > Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com> > > Acked-by: Stephen Boyd <sboyd@kernel.org> > > --- > > drivers/clk/clk-qoriq.c | 14 +++++++++++++- > > drivers/cpufreq/qoriq-cpufreq.c | 1 + > > 2 files changed, 14 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index > > 3a1812f..e9ae70b 100644 > > --- a/drivers/clk/clk-qoriq.c > > +++ b/drivers/clk/clk-qoriq.c > > @@ -79,7 +79,7 @@ struct clockgen_chipinfo { > > const struct clockgen_muxinfo *cmux_groups[2]; > > const struct clockgen_muxinfo *hwaccel[NUM_HWACCEL]; > > void (*init_periph)(struct clockgen *cg); > > - int cmux_to_group[NUM_CMUX]; /* -1 terminates if fewer than > > NUM_CMUX */ > > + int cmux_to_group[NUM_CMUX+1]; /* -1 terminate if fewer to > > NUM_CMUX+1 */ > > You need to add the -1 terminator to p4080, and remove the "if fewer" > comment since the whole point of this is that every array gets -1 terminated. Ok, Updated > > Why did you change "terminates" to "terminate" and "than" to "to"? > > This +1 change should be a separate patch from lx2160a support. Sure, Sending as separate patch > > -Scott
| |