lkml.org 
[lkml]   [2018]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] audit: fixed a braces coding style issue
On Fri, Sep 21, 2018 at 7:38 PM Przemysław Głębocki
<glebocki.przemyslaw@gmail.com> wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Przemysław Głębocki <glebocki.przemyslaw@gmail.com>
> ---
> kernel/audit_tree.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

I generally dislike accepting coding style patches from people who
haven't made any significant code contributions. Would you be
interested in participating in upstream audit development? We have a
number of open issues that you could take a look at if you are
interested ...

* https://github.com/linux-audit/audit-kernel/issues

> diff --git a/kernel/audit_tree.c b/kernel/audit_tree.c
> index ea43181cde4a..3d0e45fa765d 100644
> --- a/kernel/audit_tree.c
> +++ b/kernel/audit_tree.c
> @@ -112,10 +112,9 @@ static void free_chunk(struct audit_chunk *chunk)
> {
> int i;
>
> - for (i = 0; i < chunk->count; i++) {
> + for (i = 0; i < chunk->count; i++)
> if (chunk->owners[i].owner)
> put_tree(chunk->owners[i].owner);
> - }
> kfree(chunk);
> }
>
> --
> 2.17.1
>


--
paul moore
www.paul-moore.com

\
 
 \ /
  Last update: 2018-09-22 22:23    [W:0.037 / U:0.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site