Messages in this thread | | | Subject | Re: [patch V3 02/11] x86/mm/cpa: Split, rename and clean up try_preserve_large_page() | From | Dave Hansen <> | Date | Fri, 21 Sep 2018 09:22:29 -0700 |
| |
On 09/17/2018 07:29 AM, Thomas Gleixner wrote: > Avoid the extra variable and gotos by splitting the function into the > actual algorithm and a callable function which contains the lock > protection. > > Rename it to should_split_large_page() while at it so the return values make > actually sense. > > Clean up the code flow, comments and general whitespace damage while at it. No > functional change. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
This one is getting a wee bit hard to follow from the diff, but the cleanup and rename looks nice.
Reviewed-by: Dave Hansen <dave.hansen@intel.com>
| |