lkml.org 
[lkml]   [2018]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH AUTOSEL 4.18 032/136] arm64: fix infinite stacktrace
Date
On Tue, Sep 18, 2018 at 12:00:51PM +0100, Will Deacon wrote:
>On Tue, Sep 18, 2018 at 06:55:34AM -0400, Mikulas Patocka wrote:
>> This patch is not correct, because the stacktrace is supposed to work
>> around discontiguous interrupt stacks.
>>
>> You should replace 'frame->fp <= fp' with 'frame->fp == fp'.
>
>No, just drop the patch. It was already reverted upstream in
>e87a4a92fba3. Can the AUTOSEL robot check for upstream reverts?

It does! Once when it grabs the patch and once right before Greg sees a
pull request. There's a (rather large - ~2 week) time gap in between
when fixes/reverts sneak in.

Thanks for the review, I'll drop the patch.

--
Thanks,
Sasha
\
 
 \ /
  Last update: 2018-09-21 16:59    [W:0.099 / U:0.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site