Messages in this thread | | | From | Souptick Joarder <> | Date | Fri, 21 Sep 2018 15:33:27 +0530 | Subject | Re: [PATCH] kernel/kcov: Replace vm_insert_page with vmf_insert_page |
| |
On Fri, Sep 21, 2018 at 3:06 PM Andrey Ryabinin <aryabinin@virtuozzo.com> wrote: > > On 09/20/2018 10:12 PM, Souptick Joarder wrote: > > There is a plan to replace vm_insert_page with new API > > vmf_insert_page. As part of it, converting vm_insert_page > > to use vmf_insert_page. > > > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > > --- > > kernel/kcov.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/kernel/kcov.c b/kernel/kcov.c > > index 3ebd09e..8900d8e 100644 > > --- a/kernel/kcov.c > > +++ b/kernel/kcov.c > > @@ -293,8 +293,9 @@ static int kcov_mmap(struct file *filep, struct vm_area_struct *vma) > > spin_unlock(&kcov->lock); > > for (off = 0; off < size; off += PAGE_SIZE) { > > page = vmalloc_to_page(kcov->area + off); > > - if (vm_insert_page(vma, vma->vm_start + off, page)) > > - WARN_ONCE(1, "vm_insert_page() failed"); > > + if (vmf_insert_page(vma, vma->vm_start + off, page) > > + != VM_FAULT_NOPAGE) > > + WARN_ONCE(1, "vmf_insert_page() failed"); > > Nack, don't see the reason for such change, it only makes code worse.
Yes, it needed. Going forward vm_insert_page will be converted to vmf_insert_page. As part of it, this code has to be converted to use vmf_insert_page(). please refer below commit on linus tree - 1c8f422059ae5da07db74
| |