Messages in this thread | | | Date | Fri, 21 Sep 2018 00:00:59 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH 5/5] RISC-V: Avoid corrupting the upper 32-bit of phys_addr_t in ioremap |
| |
On Tue, Sep 18, 2018 at 05:19:17PM +0800, Zong Li wrote: > From: Vincent Chen <vincentc@andestech.com> > > For 32bit, the upper 32-bit of phys_addr_t will be flushed to zero > after AND with PAGE_MASK because the data type of PAGE_MASK is > unsigned long. To fix this problem, the page alignment is done by > subtracting the page offset instead of AND with PAGE_MASK. > > Signed-off-by: Vincent Chen <vincentc@andestech.com>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |