Messages in this thread | | | From | Richard Weinberger <> | Subject | Re: [PATCH] Revert "ubifs: xattr: Don't operate on deleted inodes" | Date | Thu, 20 Sep 2018 09:10:44 +0200 |
| |
Am Donnerstag, 20. September 2018, 04:30:41 CEST schrieb Joel Stanley: > On Mon, 17 Sep 2018 at 07:30, Richard Weinberger <richard@nod.at> wrote: > > > > This reverts commit 11a6fc3dc743e22fb50f2196ec55bee5140d3c52. > > UBIFS wants to assert that xattr operations are only issued on files > > with positive link count. The said patch made this operations return > > -ENOENT for unlinked files such that the asserts will no longer trigger. > > This was wrong since xattr operations are perfectly fine on unlinked > > files. > > Instead the assertions need to be fixed/removed. > > > > Cc: <stable@vger.kernel.org> > > Fixes: 11a6fc3dc743 ("ubifs: xattr: Don't operate on deleted inodes") > > Reported-by: Koen Vandeputte <koen.vandeputte@ncentric.com> > > Signed-off-by: Richard Weinberger <richard@nod.at> > > The bad commit 11a6fc3dc743 was included in 4.18.7, and broke our > systems which use overlayfs on top of ubifs. > > This patch didn't apply cleanly for me to 4.18.8 (an encoding issue?), > but I did a revert of the offending commit which did the trick. > > Tested-by: Joel Stanley <joel@jms.id.au>
Thanks a lot for testing and sorry for the breakage. :-(
Thanks, //richard
| |