Messages in this thread | | | Date | Wed, 19 Sep 2018 16:40:19 -0600 | From | Keith Busch <> | Subject | Re: [PATCH 6/7] mm/gup: Combine parameters into struct |
| |
On Wed, Sep 19, 2018 at 03:02:49PM -0600, Keith Busch wrote: > if (is_hugepd(__hugepd(pmd_val(pmdval)))) { > - page = follow_huge_pd(vma, address, > - __hugepd(pmd_val(pmdval)), flags, > - PMD_SHIFT); > + page = follow_huge_pd(ctx->vma, ctx->address, > + __hugepd(pmd_val(pmdval)), > + ctx->flags, PGDIR_SHIFT);
Shoot, that should have been PMD_SHIFT.
I'll let this current set sit a little longer before considering v2.
| |