lkml.org 
[lkml]   [2018]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.9 55/62] ALSA: ad1816a: Fix sparse warning wrt PCM format type
    Date
    From: Takashi Iwai <tiwai@suse.de>

    [ Upstream commit d63f33d3f083bdb3a7c2dfd623f4d811b2a8d772 ]

    The PCM format type is with __bitwise, and it can't be converted from
    integer implicitly. Instead of an ugly cast, declare the function
    argument of snd_ad1816a_get_format() with the proper snd_pcm_format_t
    type.

    This fixes the sparse warning like:
    sound/isa/ad1816a/ad1816a_lib.c:93:14: warning: restricted snd_pcm_format_t degrades to integer

    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    sound/isa/ad1816a/ad1816a_lib.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/sound/isa/ad1816a/ad1816a_lib.c b/sound/isa/ad1816a/ad1816a_lib.c
    index 5c815f5fb044..099480afa6b9 100644
    --- a/sound/isa/ad1816a/ad1816a_lib.c
    +++ b/sound/isa/ad1816a/ad1816a_lib.c
    @@ -85,7 +85,8 @@ static void snd_ad1816a_write_mask(struct snd_ad1816a *chip, unsigned char reg,


    static unsigned char snd_ad1816a_get_format(struct snd_ad1816a *chip,
    - unsigned int format, int channels)
    + snd_pcm_format_t format,
    + int channels)
    {
    unsigned char retval = AD1816A_FMT_LINEAR_8;

    --
    2.17.1
    \
     
     \ /
      Last update: 2018-09-02 15:22    [W:4.441 / U:0.728 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site