lkml.org 
[lkml]   [2018]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.4 38/47] ALSA: wss: Fix sparse warning wrt PCM format type
    Date
    From: Takashi Iwai <tiwai@suse.de>

    [ Upstream commit 6be9a60efb401487a4d658ef23d652a9e6860b34 ]

    The PCM format type is with __bitwise, and it can't be converted from
    integer implicitly. Instead of an ugly cast, declare the function
    argument of snd_wss_get_format() with the proper snd_pcm_format_t
    type.

    This fixes the sparse warnings like:
    sound/isa/wss/wss_lib.c:551:14: warning: restricted snd_pcm_format_t degrades to integer

    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    sound/isa/wss/wss_lib.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/isa/wss/wss_lib.c b/sound/isa/wss/wss_lib.c
    index 913b731d2236..72b2cacc9e0e 100644
    --- a/sound/isa/wss/wss_lib.c
    +++ b/sound/isa/wss/wss_lib.c
    @@ -541,7 +541,7 @@ static unsigned char snd_wss_get_rate(unsigned int rate)
    }

    static unsigned char snd_wss_get_format(struct snd_wss *chip,
    - int format,
    + snd_pcm_format_t format,
    int channels)
    {
    unsigned char rformat;
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-09-02 15:17    [W:4.140 / U:0.320 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site