lkml.org 
[lkml]   [2018]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 50/89] pinctrl: imx: off by one in imx_pinconf_group_dbg_show()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit b4859f3edb47825f62d1b2efdd75fe7945996f49 ]

    The > should really be >= here. It's harmless because
    pinctrl_generic_get_group() will return a NULL if group is invalid.

    Fixes: ae75ff814538 ("pinctrl: pinctrl-imx: add imx pinctrl core driver")
    Reported-by: Dong Aisheng <aisheng.dong@nxp.com>
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/pinctrl/freescale/pinctrl-imx.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
    index 6e472691d8ee..17f2c5a505b2 100644
    --- a/drivers/pinctrl/freescale/pinctrl-imx.c
    +++ b/drivers/pinctrl/freescale/pinctrl-imx.c
    @@ -389,7 +389,7 @@ static void imx_pinconf_group_dbg_show(struct pinctrl_dev *pctldev,
    const char *name;
    int i, ret;

    - if (group > pctldev->num_groups)
    + if (group >= pctldev->num_groups)
    return;

    seq_printf(s, "\n");
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-09-02 15:13    [W:4.197 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site