lkml.org 
[lkml]   [2018]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 60/89] MIPS: Octeon: add missing of_node_put()
    Date
    From: Nicholas Mc Guire <hofrat@osadl.org>

    [ Upstream commit b1259519e618d479ede8a0db5474b3aff99f5056 ]

    The call to of_find_node_by_name returns a node pointer with refcount
    incremented thus it must be explicitly decremented here after the last
    usage.

    Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
    Signed-off-by: Paul Burton <paul.burton@mips.com>
    Patchwork: https://patchwork.linux-mips.org/patch/19558/
    Cc: Ralf Baechle <ralf@linux-mips.org>
    Cc: James Hogan <jhogan@kernel.org>
    Cc: linux-mips@linux-mips.org
    Cc: linux-kernel@vger.kernel.org
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    arch/mips/cavium-octeon/octeon-platform.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/arch/mips/cavium-octeon/octeon-platform.c b/arch/mips/cavium-octeon/octeon-platform.c
    index 8505db478904..1d92efb82c37 100644
    --- a/arch/mips/cavium-octeon/octeon-platform.c
    +++ b/arch/mips/cavium-octeon/octeon-platform.c
    @@ -322,6 +322,7 @@ static int __init octeon_ehci_device_init(void)
    return 0;

    pd = of_find_device_by_node(ehci_node);
    + of_node_put(ehci_node);
    if (!pd)
    return 0;

    @@ -384,6 +385,7 @@ static int __init octeon_ohci_device_init(void)
    return 0;

    pd = of_find_device_by_node(ohci_node);
    + of_node_put(ohci_node);
    if (!pd)
    return 0;

    --
    2.17.1
    \
     
     \ /
      Last update: 2018-09-02 15:11    [W:4.192 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site