lkml.org 
[lkml]   [2018]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 84/89] ALSA: au88x0: Fix sparse warning wrt PCM format type
    Date
    From: Takashi Iwai <tiwai@suse.de>

    [ Upstream commit 10d3d91e3bc4e152a580bf523e4fd6bf279ae532 ]

    The PCM format type is with __bitwise, and it can't be converted from
    integer implicitly. Instead of an ugly cast, declare the function
    argument of vortex_alsafmt_aspfmt() with the proper snd_pcm_format_t
    type.

    This fixes the sparse warning like:
    sound/pci/au88x0/au88x0_core.c:2778:14: warning: restricted snd_pcm_format_t degrades to integer

    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    sound/pci/au88x0/au88x0.h | 2 +-
    sound/pci/au88x0/au88x0_core.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/sound/pci/au88x0/au88x0.h b/sound/pci/au88x0/au88x0.h
    index bcc648bf6478..e3e31f07d766 100644
    --- a/sound/pci/au88x0/au88x0.h
    +++ b/sound/pci/au88x0/au88x0.h
    @@ -241,7 +241,7 @@ static int vortex_core_init(vortex_t * card);
    static int vortex_core_shutdown(vortex_t * card);
    static void vortex_enable_int(vortex_t * card);
    static irqreturn_t vortex_interrupt(int irq, void *dev_id);
    -static int vortex_alsafmt_aspfmt(int alsafmt, vortex_t *v);
    +static int vortex_alsafmt_aspfmt(snd_pcm_format_t alsafmt, vortex_t *v);

    /* Connection stuff. */
    static void vortex_connect_default(vortex_t * vortex, int en);
    diff --git a/sound/pci/au88x0/au88x0_core.c b/sound/pci/au88x0/au88x0_core.c
    index c308a4f70550..d3dabbd9b1f4 100644
    --- a/sound/pci/au88x0/au88x0_core.c
    +++ b/sound/pci/au88x0/au88x0_core.c
    @@ -2770,7 +2770,7 @@ static int vortex_core_shutdown(vortex_t * vortex)

    /* Alsa support. */

    -static int vortex_alsafmt_aspfmt(int alsafmt, vortex_t *v)
    +static int vortex_alsafmt_aspfmt(snd_pcm_format_t alsafmt, vortex_t *v)
    {
    int fmt;

    --
    2.17.1
    \
     
     \ /
      Last update: 2018-09-02 15:11    [W:4.404 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site