Messages in this thread | | | From | Rajat Jain <> | Date | Wed, 19 Sep 2018 10:35:22 -0700 | Subject | Re: [PATCH] pinctrl: intel: Do pin translation in other GPIO operations as well |
| |
On Wed, Sep 19, 2018 at 1:40 AM Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > > On Tue, Sep 18, 2018 at 03:14:44PM -0700, Rajat Jain wrote: > > Also consider fixing the checkpatch warning: > > > > Errors: > > * checkpatch.pl errors/warnings > > > > WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > > #48: FILE: drivers/pinctrl/intel/pinctrl-intel.c:764: > > +static int intel_gpio_to_pin(struct intel_pinctrl *pctrl, > > unsigned offset, > > Right, it is currently the "convention" used in Intel pinctrl drivers so > I did not want to change that single entry. > > We should eventually convert the whole set of Intel pinctrl drivers to > use unsigned int instead of unsigned.
OK, Thanks for the clarification.
| |