lkml.org 
[lkml]   [2018]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [REVIEW][PATCH 12/20] signal/x86: Remove pkey parameter from bad_area_nosemaphore
    From
    Date
    On 09/18/2018 01:44 PM, Thomas Gleixner wrote:
    > On Tue, 18 Sep 2018, Eric W. Biederman wrote:
    >> The function bad_area_nosemaphore always sets si_code to SEGV_MAPERR
    >> and as such can never return a pkey parameter. Therefore remove the
    >> unusable pkey parameter from bad_area_nosemaphore.

    The result of this looks nice to me. It's especially nice to see the
    scope where we have to pass around the pkey get reduced.

    I also ran the pkey selftests against the current version of your
    siginfo-testing branch. Everything passes fine on my pkey-enabled system.

    \
     
     \ /
      Last update: 2018-09-19 18:34    [W:2.708 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site