Messages in this thread | | | Subject | Re: [PATCH] net: apm: xgene: force XGene enet driver to re-balance IRQ usage | From | Florian Fainelli <> | Date | Tue, 18 Sep 2018 17:03:52 -0700 |
| |
On 09/18/2018 04:56 PM, Eric Dumazet wrote: > > > On 09/18/2018 04:27 PM, Eric Dumazet wrote: >> > >> I remember one of the napi_complete_done() change had to be reverted, >> for some obscure reason. > > > > That was not exactly a revert, :
This is what I have so far for the drivers that both use napi_complete_done() without checking the return value and implement a ndo_poll_controller() callback:
https://github.com/ffainelli/linux/commits/napi-check
> > commit 129c6cda2de2a8ac44fab096152469999b727faf > Author: Eric Dumazet <edumazet@google.com> > Date: Mon Sep 18 13:03:43 2017 -0700 > > 8139too: revisit napi_complete_done() usage > > It seems we have to be more careful in napi_complete_done() > use. This patch is not a revert, as it seems we can > avoid bug that Ville reported by moving the napi_complete_done() > test in the spinlock section. > > Many thanks to Ville for detective work and all tests. > > Fixes: 617f01211baf ("8139too: use napi_complete_done()") > Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > Tested-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Signed-off-by: David S. Miller <davem@davemloft.net> > > > > > >
-- Florian
| |