Messages in this thread | | | Subject | Re: [PATCH 2/2] video: ssd1307fb: Do not hard code active-low reset sequence | From | Michal Vokáč <> | Date | Wed, 19 Sep 2018 14:57:34 +0200 |
| |
On 19.9.2018 14:12, Fabio Estevam wrote: > Hi Michal, > > On Wed, Sep 19, 2018 at 6:18 AM, Michal Vokáč <michal.vokac@ysoft.com> wrote: >> The SSD130x OLED display reset signal is active low. Now the reset >> sequence is implemented in such a way that users are forced to >> define reset-gpios as GPIO_ACTIVE_HIGH in DT to make the reset work. >> >> Do not hard code the active-low sequence into the driver but instead >> allow the user to specify the gpio as GPIO_ACTIVE_LOW to reflect >> the real world. >> >> The only single in-tree user of the display is converted and builds >> fine. >> >> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com> >> --- >> I am not really sure wheater this should be in one commit or the DT >> changes should be done in separate commit. Just tell me and I will >> split/merge the changes as you want. Thanks. > > Please separate in two patches: one for the dts and another for the driver.
OK, thank you. I will send v2 shortly.
Michal
| |