lkml.org 
[lkml]   [2018]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH 07/11] arm/tlb: Convert to generic mmu_gather
    On Tue, Sep 18, 2018 at 03:10:34PM +0100, Will Deacon wrote:
    > > + addr = (addr & PMD_MASK) + SZ_1M;
    > > + __tlb_adjust_range(tlb, addr - PAGE_SIZE, addr + PAGE_SIZE);
    >
    > Hmm, I don't think you've got the range correct here. Don't we want
    > something like:
    >
    > __tlb_adjust_range(tlb, addr - PAGE_SIZE, 2 * PAGE_SIZE)
    >
    > to ensure that we flush on both sides of the 1M boundary?

    Argh indeed. I confused {start,size} with {start,end}. Thanks!

    \
     
     \ /
      Last update: 2018-09-19 13:31    [W:2.541 / U:0.468 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site