Messages in this thread Patch in this message | | | From | Oscar Salvador <> | Subject | [PATCH 3/5] mm/memory_hotplug: Tidy up node_states_clear_node | Date | Wed, 19 Sep 2018 12:08:17 +0200 |
| |
From: Oscar Salvador <osalvador@suse.de>
node_states_clear has the following if statements:
if ((N_MEMORY != N_NORMAL_MEMORY) && (arg->status_change_nid_high >= 0)) ...
if ((N_MEMORY != N_HIGH_MEMORY) && (arg->status_change_nid >= 0)) ...
N_MEMORY can never be equal to neither N_NORMAL_MEMORY nor N_HIGH_MEMORY.
Similar problem was found in [1]. Since this is wrong, let us get rid of it.
[1] https://patchwork.kernel.org/patch/10579155/
Signed-off-by: Oscar Salvador <osalvador@suse.de> --- mm/memory_hotplug.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index c2c7359bd0a7..131c08106d54 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1590,12 +1590,10 @@ static void node_states_clear_node(int node, struct memory_notify *arg) if (arg->status_change_nid_normal >= 0) node_clear_state(node, N_NORMAL_MEMORY); - if ((N_MEMORY != N_NORMAL_MEMORY) && - (arg->status_change_nid_high >= 0)) + if (arg->status_change_nid_high >= 0) node_clear_state(node, N_HIGH_MEMORY); - if ((N_MEMORY != N_HIGH_MEMORY) && - (arg->status_change_nid >= 0)) + if (arg->status_change_nid >= 0) node_clear_state(node, N_MEMORY); } -- 2.13.6
| |