Messages in this thread | | | From | Masahiro Yamada <> | Date | Wed, 19 Sep 2018 15:58:40 +0900 | Subject | Re: [PATCH] samples: disable CONFIG_SAMPLES for UML |
| |
Hi.
2018-09-18 17:21 GMT+09:00 Richard Weinberger <richard@nod.at>: > Am Dienstag, 18. September 2018, 05:58:33 CEST schrieb Masahiro Yamada: >> Some samples require headers installation, so commit 3fca1700c4c3 >> ("kbuild: make samples really depend on headers_install") added >> such dependency in the top Makefile. However, UML fails to build >> with CONFIG_SAMPLES=y because UML does not support headers_install. >> >> Fixes: 3fca1700c4c3 ("kbuild: make samples really depend on headers_install") >> Reported-by: Kees Cook <keescook@chromium.org> >> Cc: David Howells <dhowells@redhat.com> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > Is there anything UML can do better? > Not sure whether an arch like is supposed to install headers at all, > I guess no. :)
I just thought suppressing CONFIG_SAMPLES was a big hammer.
We could install host-arch headers for UML if we like, but I am not sure whether is is sensible...
Wait for comments in case somebody has a better solution.
-- Best Regards Masahiro Yamada
| |