lkml.org 
[lkml]   [2018]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH net-next v5 04/20] zinc: ChaCha20 x86_64 implementation
    Hi Thomas,

    On Wed, Sep 19, 2018 at 12:30 AM Thomas Gleixner <tglx@linutronix.de> wrote:
    > I'm a bit confused by this SOB chain. So above you write that it's from
    > Andy Polakovs implementation and Samuel did the changes. But here it seems
    > you are the main author. If Samuel just did some modifications then you
    > want to use the Co-developed-by tag along with his SOB.

    Thanks, I'll use that tag.

    >
    > Also I'd recommend to add a Originally-by or Based-on-code-from: Andy
    > Polyakov tag. Both are not formal tags but widely in use for attributions.

    Great idea.

    >
    > > +++ b/lib/zinc/chacha20/chacha20-x86_64-glue.h
    > > @@ -0,0 +1,100 @@
    > > +/* SPDX-License-Identifier: MIT
    >
    > Please put that into a separate one liner comment. Also this should be
    > 'GPL-2.0[+] or MIT' I think.

    I had that originally, but changed it to just MIT, since MIT is a
    subset of GPL-2.0. And looking at tree repo, it appears this is what
    others do too.

    Jason

    \
     
     \ /
      Last update: 2018-09-19 04:15    [W:3.929 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site