Messages in this thread | | | From | Krzysztof Kozlowski <> | Date | Tue, 18 Sep 2018 09:33:35 +0200 | Subject | Re: [PATCH v2 1/4] crypto: s5p-sss: Fix race in error handling |
| |
On Mon, 17 Sep 2018 at 17:10, Christoph Manszewski <c.manszewski@samsung.com> wrote: > > Remove a race condition introduced by error path in functions: > s5p_aes_interrupt and s5p_aes_crypt_start. Setting the busy field of > struct s5p_aes_dev to false made it possible for s5p_tasklet_cb to > change the req field, before s5p_aes_complete was called. > > Change the first parameter of s5p_aes_complete to struct > ablkcipher_request. Before spin_unlock, make a copy of the currently > handled request, to ensure s5p_aes_complete function call with the > correct request. > > Signed-off-by: Christoph Manszewski <c.manszewski@samsung.com> > --- > drivers/crypto/s5p-sss.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-)
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards, Krzysztof
| |