lkml.org 
[lkml]   [2018]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 067/126] net: mvneta: fix mtu change on port without link
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Yelena Krivosheev <yelena@marvell.com>

    [ Upstream commit 8466baf788ec3e18836bd9c91ba0b1a07af25878 ]

    It is incorrect to enable TX/RX queues (call by mvneta_port_up()) for
    port without link. Indeed MTU change for interface without link causes TX
    queues to stuck.

    Fixes: c5aff18204da ("net: mvneta: driver for Marvell Armada 370/XP
    network unit")
    Signed-off-by: Yelena Krivosheev <yelena@marvell.com>
    [gregory.clement: adding Fixes tags and rewording commit log]
    Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/marvell/mvneta.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/drivers/net/ethernet/marvell/mvneta.c
    +++ b/drivers/net/ethernet/marvell/mvneta.c
    @@ -3195,7 +3195,6 @@ static int mvneta_change_mtu(struct net_

    on_each_cpu(mvneta_percpu_enable, pp, true);
    mvneta_start_dev(pp);
    - mvneta_port_up(pp);

    netdev_update_features(dev);


    \
     
     \ /
      Last update: 2018-09-18 01:29    [W:4.250 / U:0.460 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site