Messages in this thread | | | Date | Tue, 18 Sep 2018 01:07:58 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH V3 2/6] perf/core: Add helper to obtain performance counter index |
| |
On Mon, Sep 17, 2018 at 09:37:14AM -0700, Reinette Chatre wrote: > On 9/17/2018 1:23 AM, Peter Zijlstra wrote:
> > I said arch/x86/include/asm/perf_events.h and call it: > > x86_perf_rdpmc_index(). > > > > This function is very much x86 specific.
> Moving it to arch/x86/include/asm/perf_event.h is not trivial since this > file is not familiar with struct perf_event.
Urgh, right you are. Does it work if you make it a regular function instead of an inline? Put the thing in arch/x86/events/core.c or so and only an extern decl in asm/perf_event.h.
| |