lkml.org 
[lkml]   [2018]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.18 082/158] f2fs: fix to detect looped node chain correctly
    Date
    4.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Chao Yu <yuchao0@huawei.com>

    [ Upstream commit 82902c06bd17dbf6e8184299842ca5c68880970f ]

    Below dmesg was printed when testing generic/388 of fstest:

    F2FS-fs (zram1): find_fsync_dnodes: detect looped node chain, blkaddr:526615, next:526616
    F2FS-fs (zram1): Cannot recover all fsync data errno=-22
    F2FS-fs (zram1): Mounted with checkpoint version = 22300d0e
    F2FS-fs (zram1): find_fsync_dnodes: detect looped node chain, blkaddr:526615, next:526616
    F2FS-fs (zram1): Cannot recover all fsync data errno=-22

    The reason is that we initialize free_blocks with free blocks of
    filesystem, so if filesystem is full, free_blocks can be zero,
    below condition will be true, so that, it will fail recovery.

    if (++loop_cnt >= free_blocks ||
    blkaddr == next_blkaddr_of_node(page))

    To fix this issue, initialize free_blocks with correct value which
    includes over-privision blocks.

    Signed-off-by: Chao Yu <yuchao0@huawei.com>
    Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/f2fs/recovery.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/fs/f2fs/recovery.c
    +++ b/fs/f2fs/recovery.c
    @@ -241,8 +241,8 @@ static int find_fsync_dnodes(struct f2fs
    struct page *page = NULL;
    block_t blkaddr;
    unsigned int loop_cnt = 0;
    - unsigned int free_blocks = sbi->user_block_count -
    - valid_user_blocks(sbi);
    + unsigned int free_blocks = MAIN_SEGS(sbi) * sbi->blocks_per_seg -
    + valid_user_blocks(sbi);
    int err = 0;

    /* get node pages in the current segment */

    \
     
     \ /
      Last update: 2018-09-18 01:20    [W:4.039 / U:0.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site