| Date | Tue, 18 Sep 2018 22:19:14 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [REVIEW][PATCH 03/20] signal/x86: Move MCE error reporting out of force_sig_info_fault |
| |
On Tue, 18 Sep 2018, Eric W. Biederman wrote: > #ifdef CONFIG_MEMORY_FAILURE > if (fault & (VM_FAULT_HWPOISON|VM_FAULT_HWPOISON_LARGE)) { > + unsigned lsb = 0;
Newline between variable declaration and code please.
> printk(KERN_ERR > "MCE: Killing %s:%d due to hardware memory corruption fault at %lx\n", > tsk->comm, tsk->pid, address);
Can you please convert that to pr_err() while at it?
> - code = BUS_MCEERR_AR; > + if (fault & VM_FAULT_HWPOISON_LARGE) > + lsb = hstate_index_to_shift(VM_FAULT_GET_HINDEX(fault)); > + if (fault & VM_FAULT_HWPOISON) > + lsb = PAGE_SHIFT; > + force_sig_mceerr(BUS_MCEERR_AR, (void __user *)address, lsb, tsk); > + return; > }
With that fixed:
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
|