lkml.org 
[lkml]   [2018]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.18 033/136] IB/core: type promotion bug in rdma_rw_init_one_mr()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit c2d7c8ff89b22ddefb1ac2986c0d48444a667689 ]

    "nents" is an unsigned int, so if ib_map_mr_sg() returns a negative
    error code then it's type promoted to a high unsigned int which is
    treated as success.

    Fixes: a060b5629ab0 ("IB/core: generic RDMA READ/WRITE API")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/infiniband/core/rw.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/infiniband/core/rw.c b/drivers/infiniband/core/rw.c
    index c8963e91f92a..3ee0adfb45e9 100644
    --- a/drivers/infiniband/core/rw.c
    +++ b/drivers/infiniband/core/rw.c
    @@ -87,7 +87,7 @@ static int rdma_rw_init_one_mr(struct ib_qp *qp, u8 port_num,
    }

    ret = ib_map_mr_sg(reg->mr, sg, nents, &offset, PAGE_SIZE);
    - if (ret < nents) {
    + if (ret < 0 || ret < nents) {
    ib_mr_pool_put(qp, &qp->rdma_mrs, reg->mr);
    return -EINVAL;
    }
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-09-17 05:01    [W:4.091 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site