lkml.org 
[lkml]   [2018]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] trace,x86: Add external_interrupts to the irq_vectors class
Hi Daniel,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/x86/core]
[also build test ERROR on v4.19-rc4 next-20180913]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Daniel-Bristot-de-Oliveira/trace-x86-Add-external_interrupts-to-the-irq_vectors-class/20180917-173538
config: i386-randconfig-x003-201837 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All errors (new ones prefixed by >>):

arch/x86/kernel/irq.c: In function 'do_IRQ':
>> arch/x86/kernel/irq.c:240:2: error: implicit declaration of function 'trace_external_interrupt_entry'; did you mean 'thermal_interrupt'? [-Werror=implicit-function-declaration]
trace_external_interrupt_entry(vector);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
thermal_interrupt
>> arch/x86/kernel/irq.c:259:2: error: implicit declaration of function 'trace_external_interrupt_exit'; did you mean 'thermal_interrupt'? [-Werror=implicit-function-declaration]
trace_external_interrupt_exit(vector);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
thermal_interrupt
cc1: some warnings being treated as errors

vim +240 arch/x86/kernel/irq.c

225
226
227 /*
228 * do_IRQ handles all normal device IRQ's (the special
229 * SMP cross-CPU interrupts have their own specific
230 * handlers).
231 */
232 __visible unsigned int __irq_entry do_IRQ(struct pt_regs *regs)
233 {
234 struct pt_regs *old_regs = set_irq_regs(regs);
235 struct irq_desc * desc;
236 /* high bit used in ret_from_ code */
237 unsigned vector = ~regs->orig_ax;
238
239 entering_irq();
> 240 trace_external_interrupt_entry(vector);
241
242 /* entering_irq() tells RCU that we're not quiescent. Check it. */
243 RCU_LOCKDEP_WARN(!rcu_is_watching(), "IRQ failed to wake up RCU");
244
245 desc = __this_cpu_read(vector_irq[vector]);
246
247 if (!handle_irq(desc, regs)) {
248 ack_APIC_irq();
249
250 if (desc != VECTOR_RETRIGGERED) {
251 pr_emerg_ratelimited("%s: %d.%d No irq handler for vector\n",
252 __func__, smp_processor_id(),
253 vector);
254 } else {
255 __this_cpu_write(vector_irq[vector], VECTOR_UNUSED);
256 }
257 }
258
> 259 trace_external_interrupt_exit(vector);
260 exiting_irq();
261
262 set_irq_regs(old_regs);
263 return 1;
264 }
265

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2018-09-17 12:25    [W:0.034 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site